Skip to content

Add simple-matrix-bot-lib to sdks discover page#1024

Merged
MadLittleMods merged 2 commits into
masterfrom
unknown repository
Jul 22, 2021
Merged

Add simple-matrix-bot-lib to sdks discover page#1024
MadLittleMods merged 2 commits into
masterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jul 17, 2021

No description provided.

@ghost
Copy link
Copy Markdown
Author

ghost commented Jul 17, 2021

Commit 088de58 has an inaccurate description.

@MadLittleMods
Copy link
Copy Markdown
Contributor

Commit 088de58 has an inaccurate description.

@KrazyKirby99999 I'm confused. You linked the current commit (088de58) as the one that is inaccurate? Can you update this PR?

@ghost
Copy link
Copy Markdown
Author

ghost commented Jul 20, 2021

The changes of the commit are correct, but the commit message should be "
Initial simple-matrix-bot-lib discover page". Sorry for the confusion.

Copy link
Copy Markdown
Contributor

@MadLittleMods MadLittleMods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out locally and looks good. Only a small change suggested 🙂

http://localhost:8000/sdks/#simple-matrix-bot-lib
Screen Shot 2021-07-21 at 11 08 59 PM

http://localhost:8000/docs/projects/sdk/simple-matrix-bot-lib
Screen Shot 2021-07-21 at 11 10 34 PM

Comment thread gatsby/content/projects/sdks/simple-matrix-bot-lib.mdx Outdated
Add link to "matrix-nio" text.

Co-authored-by: Eric Eastwood <madlittlemods@gmail.com>
@ghost
Copy link
Copy Markdown
Author

ghost commented Jul 22, 2021

The suggestion should be accepted now.

@MadLittleMods MadLittleMods merged commit e8ace17 into matrix-org:master Jul 22, 2021
@MadLittleMods
Copy link
Copy Markdown
Contributor

Merged! Thanks for adding your project @KrazyKirby99999 🐂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant