Conversation
baf6cc0 to
e6857ed
Compare
Signed-off-by: Alexandre Franke <alexandre.franke@matrix.org>
Contributor
Author
BeforeAfterNotes
|
anoadragon453
requested changes
Sep 27, 2021
Member
anoadragon453
left a comment
There was a problem hiding this comment.
Some minor clarifying points, but otherwise looks good to me.
Design may want to modify the colour scheme at some point, but from your screenshot I think it looks pretty slick for a first pass (though I have no idea about accessibility for instance).
added 2 commits
September 27, 2021 09:46
Signed-off-by: Alexandre Franke <alexandre.franke@matrix.org>
Signed-off-by: Alexandre Franke <alexandre.franke@matrix.org>
anoadragon453
approved these changes
Sep 27, 2021
This was referenced Dec 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


For a more modern interface to explore the API.