Make other API available in the playground#1246
Merged
Merged
Conversation
added 3 commits
February 2, 2022 14:06
Signed-off-by: Alexandre Franke <alexandre.franke@matrix.org>
Signed-off-by: Alexandre Franke <alexandre.franke@matrix.org>
Signed-off-by: Alexandre Franke <alexandre.franke@matrix.org>
Signed-off-by: Alexandre Franke <alexandre.franke@matrix.org>
richvdh
approved these changes
Feb 16, 2022
Member
richvdh
left a comment
There was a problem hiding this comment.
seems generally sensible to me
Contributor
Author
|
Something’s amiss.
Looks like it didn’t deploy? 17 hours after it’s been merged, doesn’t seem right… |
Member
|
hrm, thanks @afranke; will take a look |
Member
|
so it turns out the webhook listener was ooming. Hopefully that is now improved with matrix-org/gha-webhook-listener#8. |
Contributor
Author
|
Thanks for looking into it and for fixing it so quickly. Had a look at the hook changes, they look good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a combo that allows selection of API amongst the ones we generate.
Depends on matrix-org/matrix-spec-proposals#3684
Fixes matrix-org/matrix-spec-proposals#1458
Preview: https://pr1246--matrix-org-previews.netlify.app