Synapse 1.53#1273
Merged
Merged
Conversation
richvdh
requested changes
Feb 22, 2022
|
|
||
| To avoid being overly intensive on resources by making too many queries to the database, Synapse maintains several in-memory caches to store data it needs to use frequently. However, this comes with the inconvenience that, if Synapse needs to store too much data, these caches can become fairly big and occupy too much space in the host's memory. | ||
|
|
||
| Historically, Synapse has been dealing with this issue by having set sizes for each cache, either hardcoded or set in the configuration, and evicting the oldest items when exceeding this size. But relying just on this solution alone comes with its own issues. For example, adding an entry to the cache that Synapse will only rarely use might cause it to evict other entries that it needs to use more often, thus forcing Synapse to query the database for them again. |
Member
There was a problem hiding this comment.
Suggested change
| Historically, Synapse has been dealing with this issue by having set sizes for each cache, either hardcoded or set in the configuration, and evicting the oldest items when exceeding this size. But relying just on this solution alone comes with its own issues. For example, adding an entry to the cache that Synapse will only rarely use might cause it to evict other entries that it needs to use more often, thus forcing Synapse to query the database for them again. | |
| Historically, Synapse has dealt with this issue by having set sizes for each cache, either hardcoded or set in the configuration, and evicting the oldest items when exceeding this size. But relying just on this solution alone comes with its own issues. For example, adding an entry to the cache that Synapse will only rarely use might cause it to evict other entries that it needs to use more often, thus forcing Synapse to query the database for them again. |
Member
There was a problem hiding this comment.
we haven't done anything to address the fact that a new cache entry might evict more useful entries, so the last sentence here is wrong.
Author
There was a problem hiding this comment.
I've removed that sentence entirely since it's not needed and a bit confusing anyway.
richvdh
approved these changes
Feb 22, 2022
Contributor
|
Can I get a tweetable summary in the advocacy room when this is merged :) ? |
babolivier
added a commit
that referenced
this pull request
Feb 22, 2022
This doesn't impact anything on the public website (it doesn't look like Gatsby uses the file tree we have in the repo to generate URLs), but I realised while writing #1273 that the blog post for Synapse 1.52 was in the directory for January instead of February.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And it's a chunky one.
To be merged only once 1.53 is released.
Preview: https://pr1273--matrix-org-previews.netlify.app