Fix olm/megolm links#1291
Merged
Merged
Conversation
Member
|
@thibaultamartin I'm on hol for a couple days, so I'm not going to look at this very carefully right now, but if the it looks sane from a quick glance, and if the linked file isn't a 404, then 👍 |
Member
|
I'll take a look |
richvdh
requested changes
Mar 22, 2022
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
richvdh
reviewed
Mar 22, 2022
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
lgtm, but needs to wait for https://github.com/matrix-org/matrix-ansible-private/pull/4658
Thanks!
richvdh
approved these changes
Mar 22, 2022
Author
|
Why does it need to wait? The current link 404s anyway. |
Member
|
fair point |
Author
|
🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These previously came up with a "no file named docs/[meg]olm.rst on master" message from GitLab.
Preview: https://pr1291--matrix-org-previews.netlify.app