Synapse 1.55#1295
Merged
Merged
Conversation
anoadragon453
approved these changes
Mar 24, 2022
Comment on lines
+34
to
+36
| As part of our work to integrate [Poetry](https://python-poetry.org/) in Synapse | ||
| (which in turn will enable a lot of cool things, such as reproducible builds), | ||
| we have recently moved the way we package this tool. As of this release, |
Member
There was a problem hiding this comment.
So from DMR's response on Matrix, it's because it was necessary to have synctl available on the user's path when installing Synapse via poetry, as it only (for now) supports a subset of the ways setuptools exposes binaries.
But we don't need to go into that much detail in this blog post really. What you wrote works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will send Thib tweetable contents once merged and deployed.
Preview: https://pr1295--matrix-org-previews.netlify.app