Skip to content

Try to fix Thunderbird redirect#1318

Merged
thibaultamartin merged 2 commits into
matrix-org:masterfrom
freaktechnik:patch-1
May 19, 2022
Merged

Try to fix Thunderbird redirect#1318
thibaultamartin merged 2 commits into
matrix-org:masterfrom
freaktechnik:patch-1

Conversation

@freaktechnik
Copy link
Copy Markdown

@freaktechnik freaktechnik commented Apr 24, 2022

@afranke
Copy link
Copy Markdown
Contributor

afranke commented Apr 24, 2022

🤔 Something must still be missing, the preview shows a 404.

Don’t mind the spell check CI step failing, that’s from an unrelated commit in master.

@afranke
Copy link
Copy Markdown
Contributor

afranke commented Apr 24, 2022

What happens if you remove the file altogether? Please test locally before pushing.

@MadLittleMods MadLittleMods added the ecosystem Adding and removing ecosystem projects label May 3, 2022
@thibaultamartin
Copy link
Copy Markdown
Contributor

🤔 Something must still be missing, the preview shows a 404.

I pulled the latest changes and ran npm run develop in the gatsby/ folder, http://localhost:8000/docs/projects/client/thunderbird seems to work. I get to this page by clicking the link in http://localhost:8000/docs/projects/try-matrix-now

When you mention the preview, you refer to netlify?

@afranke
Copy link
Copy Markdown
Contributor

afranke commented May 19, 2022

When you mention the preview, you refer to netlify?

Yes.

@afranke
Copy link
Copy Markdown
Contributor

afranke commented May 19, 2022

@freaktechnik
Copy link
Copy Markdown
Author

freaktechnik commented May 19, 2022

Weirdly on netlify https://pr1318--matrix-org-previews.netlify.app/page-data/docs/projects/client/mozilla-thunderbird/page-data.json exists, while on matrix.org it is https://matrix.org/page-data/docs/projects/client/thunderbird/page-data.json

From what I can tell the branch state that this is based on should generate the latter.

Edit: I see the gatsby build uses a cache, could this be a caching issue?

@thibaultamartin
Copy link
Copy Markdown
Contributor

thibaultamartin commented May 19, 2022

Given pulling this branch and running it locally fixes the issue, I'm tempted to consider it to be a Netlify issue and merge it.

If nobody screams by tomorrow 09:00 CEST I will press the scary button.

@afranke
Copy link
Copy Markdown
Contributor

afranke commented May 19, 2022

Maybe rerun the action, just to see?

@thibaultamartin
Copy link
Copy Markdown
Contributor

Maybe rerun the action, just to see?

I must be doing something wrong, after re-running the rebuild of the website if I try to re-run the deployment to Netlify it is simply skipped

@freaktechnik
Copy link
Copy Markdown
Author

I think it did re-build and deploy after my merge, however if this is a caching issue it still persists. It might only re-build that page if the Thunderbird md is touched, and somehow the last PR didn't make it into the cache yet?

@freaktechnik
Copy link
Copy Markdown
Author

The netlify preview is now behaving correctly for me.

@thibaultamartin thibaultamartin merged commit 7a8ad81 into matrix-org:master May 19, 2022
@thibaultamartin
Copy link
Copy Markdown
Contributor

It does indeed, thanks @freaktechnik!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ecosystem Adding and removing ecosystem projects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants