Skip to content

Moderation page improvements and remove deprecated /delete_room synapse api#1462

Merged
thibaultamartin merged 8 commits into
masterfrom
unknown repository
Oct 18, 2022
Merged

Moderation page improvements and remove deprecated /delete_room synapse api#1462
thibaultamartin merged 8 commits into
masterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Sep 26, 2022

Closes #1281

I renamed the file, does that affect anything?
Edit: Seems to work well on the netlify preview.

Preview: https://pr1462--matrix-org-previews.netlify.app

@ghost ghost mentioned this pull request Sep 26, 2022
Copy link
Copy Markdown
Contributor

@thibaultamartin thibaultamartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating it! This guide is now severely outdated and will require a nearly completely rewrite.

In the meantime your changes are welcome. I left suggestions to point to more up to date APIs from the spec website. Please review and apply, and we can merge this in :)

Comment thread gatsby/content/docs/moderation-guide.mdx Outdated
Comment thread gatsby/content/docs/moderation-guide.mdx Outdated
Comment thread gatsby/content/docs/moderation-guide.mdx Outdated
Comment thread gatsby/content/docs/moderation-guide.mdx Outdated
uranuspucksaxophone and others added 4 commits October 5, 2022 17:08
Co-authored-by: Thibault Martin <thibaultamartin@users.noreply.github.com>
Co-authored-by: Thibault Martin <thibaultamartin@users.noreply.github.com>
Co-authored-by: Thibault Martin <thibaultamartin@users.noreply.github.com>
Co-authored-by: Thibault Martin <thibaultamartin@users.noreply.github.com>
@ghost ghost requested a review from thibaultamartin October 5, 2022 15:09
@ghost
Copy link
Copy Markdown
Author

ghost commented Oct 5, 2022

@thibaultamartin Is the delete room api curl request command correct?

@thibaultamartin
Copy link
Copy Markdown
Contributor

@thibaultamartin Is the delete room api curl request command correct?

I believe it is, is there anything that makes you think it's not?

@ghost
Copy link
Copy Markdown
Author

ghost commented Oct 14, 2022

@thibaultamartin Thanks for answering.

No, it's just that I've never used curl to send Matrix commands before.
Do you think this is ready to merge (RTM)?

@thibaultamartin thibaultamartin merged commit a0c99f0 into matrix-org:master Oct 18, 2022
@thibaultamartin
Copy link
Copy Markdown
Contributor

Thanks for helping with the docs :)

@ghost ghost deleted the moderation-page-improvements branch October 18, 2022 14:59
-H "Authorization: Bearer $token" -XPOST \
curl 'https://matrix.org/_synapse/admin/v2/rooms/!roomid:matrix.org' \
-H "Authorization: Bearer $token" -X DELETE \
-d'{"new_room_user_id": "@abuse:matrix.org", "message": "This room has been removed from the matrix.org homeserver due to violating the terms of use.", "room_name": "Room unavailable"}'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uranuspucksaxophone I think you need to add block: true here for this to be equivalent to the shutdown_room API. Otherwise you are just deleting it but not disallowing people from joining in the future.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by #1524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Moderation guide tells you to use API that no longer exists

2 participants