Skip to content

Conversation

@awtj8o81ryywg793
Copy link
Contributor

Description

Add names (via the aria-label attribute) to external links in footer.

Related issues

Closes #3091.

Role

Individual not affiliated with any project relevant to this PR.

Timeline

There’s no immediate deadline, so feel free to review this PR whenever you can.

Signoff

Please sign off your individual commits or whole pull request.

Signed-off-by: Jack S. <181536874+awtj8o81ryywg793@users.noreply.github.com>
@awtj8o81ryywg793 awtj8o81ryywg793 marked this pull request as ready for review December 21, 2025 01:32
@awtj8o81ryywg793 awtj8o81ryywg793 requested a review from a team as a code owner December 21, 2025 01:32
Signed-off-by: Jack S. <181536874+awtj8o81ryywg793@users.noreply.github.com>
@HarHarLinks HarHarLinks added the accessibility A WCAG 2.1 AA requirement is not met label Dec 22, 2025
Copy link
Collaborator

@HarHarLinks HarHarLinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WAVE is happy and I think this makes sense. Firefox a11y devtools day that icons should also have alt text which they don't. I don't know the best practices but my feeling here is since the link labels give the context already, the icons should probably be aria-hidden?

Let me know if you wanna tweak or merge as-is.

@awtj8o81ryywg793
Copy link
Contributor Author

awtj8o81ryywg793 commented Dec 22, 2025

Quoted from a previous comment:

Firefox a11y devtools day that icons should also have alt text which they don't. I don't know the best practices but my feeling here is since the link labels give the context already, the icons should probably be aria-hidden?

Let me know if you wanna tweak

Let me tweak it. See 1c0aa85.

Signed-off-by: Jack S. <181536874+awtj8o81ryywg793@users.noreply.github.com>
Copy link
Collaborator

@HarHarLinks HarHarLinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. Do you happen to have any references that pointed to this being the best practice solution? It must be a common case, right?

@HarHarLinks HarHarLinks requested a review from MTRNord December 23, 2025 00:26
@awtj8o81ryywg793
Copy link
Contributor Author

awtj8o81ryywg793 commented Dec 23, 2025

Quoted from a previous comment:

Do you happen to have any references that pointed to this being the best practice solution?

I'm afraid I do not. I just agreed with your rationale. The SVGs are decorative, and since the link itself contains an aria-label attribute, there isn't really a need for anything else. Thinking about it, I think adding a title attribute would be a good idea too. As the A11y Collective states:

The key takeaway here is that aria-label is for assistive technology and title is for visual aids. Each serves its purpose, but they should never be swapped or relied upon interchangeably.

Source: https://www.a11y-collective.com/blog/aria-label-vs-title/

Whilst we’re at it, I wonder if the alt text should be changed to read as "Matrix.org on <platform>" or "The Matrix.org Foundation on <platform>" instead of "Matrix on <platform>." This is because the current text reads, "View the Matrix ecosystem on <platform>," which is inaccurate, as we only link to Matrix.org projects. In contrast, the improved text states, "View The Matrix.org Foundation on <platform>," accurately reflecting the destination of the link.

@awtj8o81ryywg793 awtj8o81ryywg793 marked this pull request as draft December 23, 2025 01:26
Signed-off-by: Jack S. <181536874+awtj8o81ryywg793@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility A WCAG 2.1 AA requirement is not met

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accessibility issues in the footer

2 participants