-
-
Notifications
You must be signed in to change notification settings - Fork 402
Fix: Add names to external links in footer #3113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix: Add names to external links in footer #3113
Conversation
Signed-off-by: Jack S. <181536874+awtj8o81ryywg793@users.noreply.github.com>
Signed-off-by: Jack S. <181536874+awtj8o81ryywg793@users.noreply.github.com>
HarHarLinks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WAVE is happy and I think this makes sense. Firefox a11y devtools day that icons should also have alt text which they don't. I don't know the best practices but my feeling here is since the link labels give the context already, the icons should probably be aria-hidden?
Let me know if you wanna tweak or merge as-is.
|
Quoted from a previous comment:
Let me tweak it. See |
Signed-off-by: Jack S. <181536874+awtj8o81ryywg793@users.noreply.github.com>
HarHarLinks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense. Do you happen to have any references that pointed to this being the best practice solution? It must be a common case, right?
|
Quoted from a previous comment:
I'm afraid I do not. I just agreed with your rationale. The SVGs are decorative, and since the link itself contains an
Source: https://www.a11y-collective.com/blog/aria-label-vs-title/ Whilst we’re at it, I wonder if the alt text should be changed to read as "Matrix.org on <platform>" or "The Matrix.org Foundation on <platform>" instead of "Matrix on <platform>." This is because the current text reads, "View the Matrix ecosystem on <platform>," which is inaccurate, as we only link to Matrix.org projects. In contrast, the improved text states, "View The Matrix.org Foundation on <platform>," accurately reflecting the destination of the link. |
Signed-off-by: Jack S. <181536874+awtj8o81ryywg793@users.noreply.github.com>
Description
Add names (via the
aria-labelattribute) to external links in footer.Related issues
Closes #3091.
Role
Individual not affiliated with any project relevant to this PR.
Timeline
There’s no immediate deadline, so feel free to review this PR whenever you can.
Signoff
Please sign off your individual commits or whole pull request.