This repository was archived by the owner on Nov 25, 2022. It is now read-only.
Use the redis server in the sytest image#86
Merged
Conversation
As of matrix-org/sytest#928, the sytest-synapse images support a redis server, so we no longer need to docker-compose.
richvdh
requested review from
erikjohnston
and removed request for
erikjohnston
erikjohnston
approved these changes
Aug 11, 2020
Member
erikjohnston
left a comment
erikjohnston
left a comment
There was a problem hiding this comment.
I think this works. After merge we should double check the test output logs to make sure it is connecting to redis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of matrix-org/sytest#928, the sytest-synapse images
support a redis server, so we no longer need to docker-compose.