Do not emit Infinity / -Infinity / NaN values from canonicaljson.#32
Merged
Conversation
auscompgeek
reviewed
Aug 18, 2020
erikjohnston
approved these changes
Aug 19, 2020
Member
erikjohnston
left a comment
erikjohnston
left a comment
There was a problem hiding this comment.
Do we need to scream from the rooftops about this change in a changelog?
Member
Author
I don't think so, but maybe. Do you think this is worthy of a release? I guess it is backwards incompatible which definitely means some light screaming. 👍 |
Member
Author
|
I've added a note to the changelog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per matrix-org/synapse#8106, we shouldn't be serializing these values to JSON since they're not standard JSON.