Avoid copying frozendicts#8
Merged
Merged
Conversation
erikjohnston
approved these changes
Mar 29, 2018
Member
erikjohnston
left a comment
erikjohnston
left a comment
There was a problem hiding this comment.
I'm wondering if we should have a third default encoder that doesn't handle frozendicts, which can be used when we've set the synapse.events.USE_FROZEN_DICTS to False? I'm not sure if we use frozendicts elsewhere.
I guess the overhead of default isn't high if it never encounters a frozendict?
It's not cheap.
richvdh
force-pushed
the
rav/no_copy_frozendict
branch
from
0a9f850 to
e1fe5ea
Compare
Member
Author
I really don't think so. It's only called if simplejson doesn't recognise the type being serialised, so unless we have frozendicts it will never be called (or rather, if it is, it's on an unrecognised type which is going to fail anyway). So I don't think it's worth having another encoder. |
richvdh
added a commit
that referenced
this pull request
Apr 13, 2018
Since #8, we poke directly into frozendict._dict; it turns out this has only existed since 1.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not cheap.
(includes #7)