Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Add a distributed lock#10269

Merged
richvdh merged 14 commits into
erikj/async_federation_base_branchfrom
erikj/lock
Jun 29, 2021
Merged

Add a distributed lock#10269
richvdh merged 14 commits into
erikj/async_federation_base_branchfrom
erikj/lock

Conversation

@erikjohnston
Copy link
Copy Markdown
Member

This adds a simple best effort locking mechanism that works cross workers.

@erikjohnston erikjohnston requested a review from a team June 29, 2021 15:45
Comment thread synapse/storage/databases/main/lock.py Outdated
Comment thread synapse/storage/databases/main/lock.py Outdated
Comment thread tests/storage/databases/main/test_lock.py
@erikjohnston erikjohnston requested a review from a team June 29, 2021 16:57
Comment thread synapse/storage/databases/main/lock.py Outdated
allow_none=True,
desc="is_lock_still_valid",
)
# If there is an entry and it has not timed out, then we still hold the lock
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I don't think I meant to delete this comment in my suggestion.

Comment thread changelog.d/10269.misc Outdated
Comment thread synapse/storage/databases/main/lock.py Outdated
Comment thread synapse/storage/databases/main/lock.py Outdated
Comment thread synapse/storage/databases/main/lock.py Outdated
Comment thread synapse/storage/databases/main/lock.py Outdated
Comment thread synapse/storage/databases/main/lock.py Outdated
Comment thread synapse/storage/databases/main/lock.py
Copy link
Copy Markdown
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread synapse/storage/databases/main/lock.py Outdated
@richvdh richvdh merged commit 85d237e into erikj/async_federation_base_branch Jun 29, 2021
@richvdh richvdh deleted the erikj/lock branch June 29, 2021 18:15
aaronraimist added a commit to aaronraimist/synapse that referenced this pull request Jun 30, 2021
Synapse 1.37.1rc1 (2021-06-29)
==============================

Features
--------

- Handle inbound events from federation asynchronously. ([\matrix-org#10269](matrix-org#10269), [\matrix-org#10272](matrix-org#10272))
aaronraimist added a commit to aaronraimist/synapse that referenced this pull request Jul 1, 2021
Synapse 1.37.1 (2021-06-30)
===========================

This release resolves issues (such as [matrix-org#9490](matrix-org#9490)) where one busy room could cause head-of-line blocking, starving Synapse from processing events in other rooms, and causing all federated traffic to fall behind. Synapse 1.37.1 processes inbound federation traffic asynchronously, ensuring that one busy room won't impact others. Please upgrade to Synapse 1.37.1 as soon as possible, in order to increase resilience to other traffic spikes.

No significant changes since v1.37.1rc1.

Synapse 1.37.1rc1 (2021-06-29)
==============================

Features
--------

- Handle inbound events from federation asynchronously. ([\matrix-org#10269](matrix-org#10269), [\matrix-org#10272](matrix-org#10272))
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jul 1, 2021
Synapse 1.37.1 (2021-06-30) ===========================

This release resolves issues (such as
[#9490](matrix-org/synapse#9490)) where
one busy room could cause head-of-line blocking, starving Synapse
from processing events in other rooms, and causing all federated
traffic to fall behind. Synapse 1.37.1 processes inbound federation
traffic asynchronously, ensuring that one busy room won't impact
others. Please upgrade to Synapse 1.37.1 as soon as possible, in
order to increase resilience to other traffic spikes.

No significant changes since v1.37.1rc1.


Synapse 1.37.1rc1 (2021-06-29) ==============================

Features --------

- Handle inbound events from federation asynchronously.
([\#10269](matrix-org/synapse#10269),
[\#10272](matrix-org/synapse#10272))
babolivier added a commit to matrix-org/synapse-dinsic that referenced this pull request Sep 1, 2021
Synapse 1.37.1 (2021-06-30)
===========================

This release resolves issues (such as [#9490](matrix-org/synapse#9490)) where one busy room could cause head-of-line blocking, starving Synapse from processing events in other rooms, and causing all federated traffic to fall behind. Synapse 1.37.1 processes inbound federation traffic asynchronously, ensuring that one busy room won't impact others. Please upgrade to Synapse 1.37.1 as soon as possible, in order to increase resilience to other traffic spikes.

No significant changes since v1.37.1rc1.

Synapse 1.37.1rc1 (2021-06-29)
==============================

Features
--------

- Handle inbound events from federation asynchronously. ([\#10269](matrix-org/synapse#10269), [\#10272](matrix-org/synapse#10272))
Fizzadar pushed a commit to Fizzadar/synapse that referenced this pull request Oct 26, 2021
Synapse 1.37.1 (2021-06-30)
===========================

This release resolves issues (such as [matrix-org#9490](matrix-org#9490)) where one busy room could cause head-of-line blocking, starving Synapse from processing events in other rooms, and causing all federated traffic to fall behind. Synapse 1.37.1 processes inbound federation traffic asynchronously, ensuring that one busy room won't impact others. Please upgrade to Synapse 1.37.1 as soon as possible, in order to increase resilience to other traffic spikes.

No significant changes since v1.37.1rc1.

Synapse 1.37.1rc1 (2021-06-29)
==============================

Features
--------

- Handle inbound events from federation asynchronously. ([\matrix-org#10269](matrix-org#10269), [\matrix-org#10272](matrix-org#10272))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants