Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Changed the is_public option which is misleading#10967

Closed
pothuguntaumesh wants to merge 1 commit into
matrix-org:developfrom
pothuguntaumesh:fixed_is_public_issue
Closed

Changed the is_public option which is misleading#10967
pothuguntaumesh wants to merge 1 commit into
matrix-org:developfrom
pothuguntaumesh:fixed_is_public_issue

Conversation

@pothuguntaumesh
Copy link
Copy Markdown

@pothuguntaumesh pothuguntaumesh commented Oct 1, 2021

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
  • Pull request includes a sign off
  • Code style is correct (run the linters)

@clokep
Copy link
Copy Markdown
Member

clokep commented Oct 1, 2021

This seems to be a duplicate of #10963?

@pothuguntaumesh
Copy link
Copy Markdown
Author

Can you please mention what's the problem in detail? I'm new to open source contribution.

@DMRobertson
Copy link
Copy Markdown
Contributor

Can you please mention what's the problem in detail? I'm new to open source contribution.

Hi @pothuguntaumesh, thanks for your contribution. @clokep was saying that another contributor took on this task slightly before you did, in pull request #10963, so the issue has been fixed now. Just unfortunate timing, sorry about that.

Since the issue has been fixed elsewhere, I'm going to close this PR. Many thanks for taking on this task.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants