This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Add pagination support to publicRooms#1121
Merged
Merged
Conversation
Contributor
|
LGTM <- not sure why I typed that yet. I should probably actually read the PR... :( |
| FROM public_room_list_stream | ||
| WHERE stream_id <= ? | ||
| GROUP BY room_id | ||
| ) grouped USING (room_id, stream_id) |
Contributor
There was a problem hiding this comment.
Will this be quick on postgres, or will you need to use window functions there?
Contributor
There was a problem hiding this comment.
Not that it really matters since the table will probably be small to start with.
Member
Author
There was a problem hiding this comment.
I've been testing on postgres, and it appears to use the right indices.
Member
Author
|
@matrixbot retest this please |
Contributor
|
LGTM |
This was referenced Sep 15, 2016
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
startandendkeys have been removed from the response to/publicRooms, and replaced bynext_batchandprev_batch(whose existence depends on if there is a next or prev batch)./publicRoomsacceptlimitandsinceparameters.{next,prev}_batchtokens tosince=. There is nodirectionparameter.sincetoken.new_roomsis returned in the response when a since token is specified and is a boolean indicating if there are new rooms. Unpublished rooms do get removed, however.limitparam is advisory, in particular synapse will return fewer rooms if they have been unpublished.The response now looks something like:
{ "chunk": [ { "canonical_alias": "#wiiiiiiiiimble:localhost:8480", "world_readable": false, "num_joined_members": 1, "room_id": "!AyxdOWyQKnFhBrCyfS:localhost:8480", "guest_can_join": false, "aliases": [ "#wiiiiiiiiimble:localhost:8480" ] } ], "prev_batch": "hKFwA6FzzQYfoWTCoW4I", "new_rooms": false }Question: If we don't specify a limit, should we return the full list (current behaviour) or should we cap it?