This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Move 'remove deleted devices' migration to latest schema version#11304
Closed
anoadragon453 wants to merge 2 commits into
Closed
Move 'remove deleted devices' migration to latest schema version#11304anoadragon453 wants to merge 2 commits into
anoadragon453 wants to merge 2 commits into
Conversation
This migration file was included as part of an old PR, and at the time of the PR's creation, the latest schema version was 64. When the PR was merged, the latest version was 65, however the migration was not moved. This meant that Synapse's on schema version 65 would not run the migration after updating. Move the migration file to the latest schema, 65. It is OK if this SQL runs twice, as it simply kicks off a background table cleanup process.
Member
|
Is this not a duplicate of #11303 |
Member
Author
Oh bother. Yes, yes it is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migration file was included as part of #10969 and at the time of the PR's creation, the latest schema version was 64. When the PR was merged, the latest version was 65, however the migration was not moved. This meant that Synapse's on schema version 65 would not run the migration after updating.
This PR moves the migration file to the latest schema, 65. It is OK if this SQL runs twice, as it simply kicks off a background table cleanup process.
Thanks to @dklimpel for spotting it.