This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Update changelog to describe changes from #12370 relative to develop#12401
Merged
Conversation
Follow-up to #12370 Context: #12370 (comment)
MadLittleMods
commented
Apr 6, 2022
| @@ -1 +1 @@ | |||
| Fix `/messages` returning backfilled and [MSC2716](https://github.com/matrix-org/synapse/pull/12319) historic messages our of order. | |||
| Update `/messages` to use historic pagination tokens by default. | |||
Contributor
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
Does "by default" make sense or should it be "if no from parameter is given" or something?
"Update" sounds a bit like a behavior change FWIW, not a bugfix.
Contributor
Author
There was a problem hiding this comment.
@clokep Updated with .feature and your language around being explicit with whether from is provided. I think "by default" also made sense 🤷
4 tasks
Member
|
(This is going to fail CI checks, but we can override those.) |
clokep
approved these changes
Apr 6, 2022
Contributor
Author
|
Thanks for the review and merge @clokep 🐸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update changelog to describe changes from #12370 relative to
developFollow-up to #12370
Context: #12370 (comment)
Pull Request Checklist
Pull request includes a changelog file. The entry should:EventStoretoEventWorkerStore.".code blocks.Pull request includes a sign off(run the linters)