This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Always try to invite the user when creating a server notice room#12704
Closed
babolivier wants to merge 3 commits into
Closed
Always try to invite the user when creating a server notice room#12704babolivier wants to merge 3 commits into
babolivier wants to merge 3 commits into
Conversation
DMRobertson
suggested changes
May 11, 2022
Comment on lines
95
to
96
| If we have not yet created a notice room for this user, create it, but don't | ||
| invite the user to it. |
Contributor
There was a problem hiding this comment.
Presumably this sentence is now incorrect?
babolivier
commented
May 11, 2022
Comment on lines
95
to
97
| If we have not yet created a notice room for this user, create it, but don't | ||
| invite the user to it. | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Suggested change
| If we have not yet created a notice room for this user, create it, but don't | |
| invite the user to it. |
Co-authored-by: David Robertson <davidr@element.io>
Contributor
Author
|
Actually this was on purpose, and this PR is not the right way to fix the issue. See #12686 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12686
get_or_create_notice_room_for_usersounds like something that should also invite the user as part of the room's creation. In fact, a previous incarnation of it did. This means that the code interacting with it might make this assumption and miss callingmaybe_invite_user_to_room, which means the user is never invited and new rooms are constantly created.Introduced in #7199