This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Jump directly to failure in gotestfmt#13180
Closed
DMRobertson wants to merge 2 commits into
Closed
Conversation
45b7440 to
f2de465
Compare
1d3360d to
e89d2b7
Compare
added 2 commits
July 12, 2022 14:46
d218a4b to
4ecbaed
Compare
Contributor
Author
|
Bugger. https://github.com/matrix-org/synapse/runs/7305162776?check_suite_focus=true demonstrates that this prints out what I expect but still scrolls to the bottom. |
Contributor
Author
|
I'm going to drop this until I get sufficiently frustrated to take another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we are seeing more complement failures (c.f. #13161) I'm more frequently encountering the following behaviour.
complement.sh ... | gotestfmt. That error is automatically generated by github when weruna shell command and appears at the bottom of the output.Fix this by tweaking go test fmt's outputter to output the special GHA error message.
To prove this works:
The annotations could probably be made more precise/better/descriptive. But this is a quick drive by and I've already spent enough time on this.