This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Draft: Prevent Failed to fetch missing state events... warning being logged every time we tried to fetch state_ids for a missing prev_event (_get_state_ids_after_missing_prev_event(...))#13249
Closed
MadLittleMods wants to merge 4 commits into
Conversation
…te for it Discovered while working on #13205
5 tasks
MadLittleMods
added
the
T-Defect
MadLittleMods
commented
Jul 11, 2022
|
|
||
| logger.debug( | ||
| "state_ids returned %i state events, %i auth events", | ||
| "_get_state_ids_after_missing_prev_event(event_id=%s): state_ids returned %i state events, %i auth events", |
Contributor
Author
There was a problem hiding this comment.
Just giving all of these a namespaced/scoped context to easily compartmentalize them and follow down the rabbit hole.
MadLittleMods
commented
Jul 11, 2022
MadLittleMods
commented
Jul 11, 2022
MadLittleMods
changed the title
event_id always being marked as failed to fetch when _get_state_ids_after_missing_prev_eventFailed to fetch missing state events... warning being logged every time we tried to fetch state_ids for a missing prev_event (_get_state_ids_after_missing_prev_event(...)
MadLittleMods
changed the title
Failed to fetch missing state events... warning being logged every time we tried to fetch state_ids for a missing prev_event (_get_state_ids_after_missing_prev_event(...)Failed to fetch missing state events... warning being logged every time we tried to fetch state_ids for a missing prev_event (_get_state_ids_after_missing_prev_event(...))
…etch Conflicts: synapse/handlers/federation_event.py
Contributor
Author
|
Closing as this was already fixed in #13258 The the remaining changes are just prefixing all of our log lines here. Can look into adding these when I have a need again ⏩ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent
Failed to fetch missing state events...warning being logged every time we tried to fetchstate_idsfor a missingprev_event(_get_state_ids_after_missing_prev_event(...))Discovered while working on #13205 (comment)
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.Pull request includes a sign off(run the linters)