This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Fix #12880 : notifications stop to work if last read event has been purged in a room#14441
Closed
laurent-treeb wants to merge 2 commits into
Closed
Fix #12880 : notifications stop to work if last read event has been purged in a room#14441laurent-treeb wants to merge 2 commits into
laurent-treeb wants to merge 2 commits into
Conversation
DMRobertson
suggested changes
Nov 16, 2022
Contributor
DMRobertson
left a comment
There was a problem hiding this comment.
This has a merge conflict. Can you resolve it?
Member
|
Also -- please update the title and description with a bit of information of what this PR accomplishes and how it does it. |
Author
Sorry no. A big merge has been done in 1.62 with this merge : #13005 So the PR may be helpfull for someone who wants to override a Synapse server before the 1.62. (I change the destination branch of the PR). |
Member
|
Closing as the author has stated they are not interested in continuing to work on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #12880 : notifications stop to work if last read event has been purged in a room
Following this comment #12880 (comment) that explains where the bug is, i choose a third way to resolve by updating the "The second query gets all event_push_actions for rooms with no read receipts." by adding rooms that have a read receipt that pointing to purged event.
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.(run the linters)