This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Update reverse_proxy.md#14739
Closed
ankit-pn wants to merge 2 commits into
Closed
Conversation
In issue matrix-org#11895, the redirect from /_matrix/client to the URL configured in web_client_location was moved to the root URL (/). This change requires local administrators to update their proxy setups to include the root URL, as the current recommendations only include proxies for /_matrix/ and /_synapse/client/. This is necessary for the new location of the redirect to be effective. This issue was raised in matrix-org#14722 by @sumpfralle
Author
|
I am new to this Matrix open source community, and I have requested none to review the code, should I have to ask it manually or it will assigned automatically? |
Contributor
This is fine, we have proper code owners defined so Thanks for your PR, I am unsure about it, and seems like we probably don't want that by default (hence not in the manual), you can find a rationale in the mentioned bug: |
Contributor
|
Right I can see that you reacted with a 👍 to this comment, so I am going to close this PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In issue #11895, the redirect from /_matrix/client to the URL configured in web_client_location was moved to the root URL (/). This change requires local administrators to update their proxy setups to include the root URL, as the current recommendations only include proxies for /_matrix/ and /_synapse/client/. This is necessary for the new location of the redirect to be effective.
This issue was raised in #14722 by @sumpfralle
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.(run the linters)