fix: check authdict before accessing any attribute

[prajjawal05]

Fixes: #15871

• Pull request is based on the develop branch
• Pull request includes a changelog file. The entry should:
  • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
  • Use markdown where necessary, mostly for code blocks.
  • End with either a period (.) or an exclamation mark (!).
  • Start with a capital letter.
  • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
• Pull request includes a sign off
• Code style is correct
  (run the linters)

[prajjawal05]

Signed-off-by: Prajjawal Agarwal prajjawalagarwal@gmail.com

[clokep]

This is very similar to #15944 and I don't think correct. If this is not a dict it should likely error not just silently ignore the invalid data.

We also want to do the checking up front on the REST endpoints so that at this point we know we have good data.

[prajjawal05]

Oh I looked into the PR mentioned above. I did not know there was a PR open for this, I came here from an issue which was open: #15871

I will close this PR, and let all conversations be in the PR which you mentioned. Thanks for checking this!

[clokep]

I will close this PR, and let all conversations be in the PR which you mentioned. Thanks for checking this!

The person who put up #15944 has stopped responding FWIW, so it is likely fine for you to take a crack at it.

[prajjawal05]

I will look at it thanks!