Adapt the default config to bind on both IPv4 and IPv6 on all platforms#2435
Conversation
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
could you add a comment about why this is a sensible thing to do (ie, explaining some of the problems discussed in #2232 ) ?
|
matrixbot: ok to test |
There was a problem hiding this comment.
I'm not sure it makes sense to apply the same logic to the rabbithole or replication listeners, not least because if you're binding them to the wildcard addresses, you're probably doing it wrong.
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
I think if we're going to do this we should probably be consistent, so this needs updating in all the other synapse/app/*.py workers.
|
generally this looks like a good idea to me. @erikjohnston do you have any thoughts? |
I have committed an attempt to abstract this in |
There was a problem hiding this comment.
I don't think we need to do this for the replication listener
There was a problem hiding this comment.
it'd probably be better to create a new logger in this file than to pass around the logger from another file.
Most deployments are on Linux (or Mac OS), so this would actually bind on both IPv4 and IPv6. Resolves matrix-org#1886. Signed-off-by: Willem Mulder <willemmaster@hotmail.com>
Binding on 0.0.0.0 when :: is specified in the bind_addresses is now allowed. This causes a warning explaining the behaviour. Configuration changed to match. See matrix-org#2232 Signed-off-by: Silke Hofstra <silke@slxh.eu>
Add listen_tcp and listen_ssl which implement Twisted's reactor.listenTCP and reactor.listenSSL for multiple addresses. Signed-off-by: Silke Hofstra <silke@slxh.eu>
silkeh
force-pushed
the
listen-ipv6-default
branch
2 times, most recently
from
7ce6531 to
8ad120b
Compare
|
The requested changes have been applied and I have rebased on develop. Edit: they have been updated. |
silkeh
force-pushed
the
listen-ipv6-default
branch
from
8ad120b to
70b20f8
Compare
There was a problem hiding this comment.
This is used outside the client reader. logging.getLogger(__name__), please.
Signed-off-by: Silke <silke@slxh.eu>
Signed-off-by: Silke <silke@slxh.eu>
silkeh
force-pushed
the
listen-ipv6-default
branch
from
3311c6b to
df0f602
Compare
|
thanks! |
4 participants
This pull requests extends #2232 with the suggestions from @ara4n:
Listen on both
::and0.0.0.0, but ignore bind errors for0.0.0.0when::was specified.This ensures that the default configuration supports all platforms.