Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Neilj/mau limits#3510

Closed
neilisfragile wants to merge 7 commits into
developfrom
neilj/mau-limits
Closed

Neilj/mau limits#3510
neilisfragile wants to merge 7 commits into
developfrom
neilj/mau-limits

Conversation

@neilisfragile
Copy link
Copy Markdown
Contributor

Creates an endpoint under admin/ to expose current MAU usage and server imposed limits to admin users

@neilisfragile neilisfragile changed the base branch from master to develop July 11, 2018 09:49
@neilisfragile neilisfragile requested a review from a team July 11, 2018 10:49
Comment thread changelog.d/3510.feature
@@ -0,0 +1 @@
Expose monthly active user data via _matrix/client/api/v1/admin/server_metrics
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r0 not v1, surely? (also, should the admin endpoints be specced?)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, good spot

@neilisfragile
Copy link
Copy Markdown
Contributor Author

Following out of band conversation - will solve this by adding the same data via the prometheus endpoint. Will go back and redo.

@krombel
Copy link
Copy Markdown
Contributor

krombel commented Jul 12, 2018

I understand the metrics aspect of adding this data. But what is the intention behind limit_mau and default_max_mau?

And as "MAU" is nowhere described: It stand for "Monthly Active Users" if I got it right.
So how you can limit that?

@neilisfragile
Copy link
Copy Markdown
Contributor Author

@krombel yup mau means monthly active user - it ties in with a broader feature that will let homeserver administrators set limits on usage of their homeserver via an optional setting

@richvdh
Copy link
Copy Markdown
Member

richvdh commented Jul 17, 2018

Will go back and redo.

I assume this means neil is continuing to work on it and it is no longer ready for review

@richvdh richvdh removed the request for review from a team July 17, 2018 16:45
@neilisfragile
Copy link
Copy Markdown
Contributor Author

Closing, superseded by #3630

@neilisfragile neilisfragile deleted the neilj/mau-limits branch August 1, 2018 14:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants