This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Add IPv6 support for Docker images#3551
Closed
LouisMT wants to merge 1 commit into
Closed
Conversation
Member
|
Can one of the admins verify this patch? |
1 similar comment
Member
|
Can one of the admins verify this patch? |
LouisMT
force-pushed
the
docker-ipv6-support
branch
2 times, most recently
from
a8065ce to
0337f2f
Compare
Signed-off-by: Louis Matthijssen <louis@u5r.nl>
LouisMT
force-pushed
the
docker-ipv6-support
branch
from
0337f2f to
19b7978
Compare
Member
|
I'm surprised this is necessary. why does the (unless the base image already has an old version of Twisted, but that seems unlikely?) |
Author
|
You're right, I saw that version 18.4 is already installed while testing. Forgot to update the PR. I'm getting a lot of 401s exactly as described in #1002, but I'll do some more research to find out what's causing it. Thanks! |
Author
|
Turns out I didn't read the reverse proxy docs well enough: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Synapse doesn't work using IPv6 (see #1002). A fix is described in #2088 and has been applied to the
Dockerfilein this PR.I understand that Debian doesn't have Twister 17 yet, but as this is a Docker image it doesn't really matter, so just install Twister 17 to make it work. The image size hasn't notably changed, as it's 492 MB before and after.
As Docker provides an IPv6 DNS server by default in custom networks (which are required to link containers since
--linkis deprecated) I think it's pretty important that IPv6 is supported in the images.Thanks!