Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Add concept of StatelessContext, take 4.#3579

Merged
erikjohnston merged 7 commits into
developfrom
erikj/stateless_contexts_4
Jul 23, 2018
Merged

Add concept of StatelessContext, take 4.#3579
erikjohnston merged 7 commits into
developfrom
erikj/stateless_contexts_4

Conversation

@erikjohnston
Copy link
Copy Markdown
Member

Based off of #3577

Supersedes: #3550

Copy link
Copy Markdown
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

Comment thread synapse/events/snapshot.py Outdated
been calculated. None if we haven't started calculating yet

_prev_state_id (str|None): If set then the event associated with the
context overrode the _prev_state_id
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems very circular. any more clues?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How unhelpful

@richvdh richvdh assigned erikjohnston and unassigned richvdh Jul 23, 2018
@erikjohnston erikjohnston merged commit 9c294ea into develop Jul 23, 2018
@erikjohnston erikjohnston deleted the erikj/stateless_contexts_4 branch September 20, 2018 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants