This repository was archived by the owner on Apr 26, 2024. It is now read-only.
only try to LL members after a non-gappy incr sync if the timeline has events#3936
Merged
Conversation
…s events. This was okay until we started to try to LL ourselves, which would then cause us to try to add LL members even if the timeline was empty. This caused an out of bounds exception
Member
Author
|
(fixes regression in #3916) |
richvdh
reviewed
Sep 24, 2018
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
well, the code looks fine I guess, so if we're really in a hurry we could merge it. However:
- I don't really understand why #3916 was a thing: why would we want to include our member event for each and every incremental sync? (element-hq/element-web#7282 talks about doing this for initial sync, but doesn't explain why it was necessary for incremental sync).
- given we seem to have sytests which test #3916, could they not be tweaked to catch this edge-case?
richvdh
reviewed
Sep 24, 2018
Member
Author
|
We LL ourselves in case it's a gappy sync, and in case we were doing LL over gappy syncs (i.e. if #3840 hadn't disabled it). In practice the members will get removed by the anti-redundancy code. In practice I guess we can move it to only apply to initial syncs for now to avoid needless work; will do so. Yup, the sytests could catch this edge case. |
richvdh
reviewed
Sep 24, 2018
Member
Author
|
(tests got added in matrix-org/sytest#496) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was okay until we started to try to LL ourselves, which would then cause
us to try to add LL members even if the timeline was empty. This caused an
out of bounds exception