This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Calculate absolute path for email templates#4069
Merged
Merged
Conversation
Contributor
|
Do we have any tests for this part of the code? |
Member
Author
|
roflololol |
Contributor
|
Okay, then, alternate question -- should one of us (me) write some, then? :) |
Member
Author
|
Ideally yes, though it's not really something that changes often, so I wouldn't make it a priority. |
hawkowl
approved these changes
Oct 19, 2018
richvdh
added a commit
that referenced
this pull request
Oct 19, 2018
This fallback didn't work, and was removed in #4069.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4065