Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Fix logic error that prevented guests from seeing the privacy policy #4133

Merged
richvdh merged 2 commits into from
Nov 2, 2018
+2 −1
Merged

Fix logic error that prevented guests from seeing the privacy policy #4133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
642505a
Fix logic error that prevented guests from seeing the privacy policy
turt2live Nov 1, 2018
552f090
Changelog
turt2live Nov 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/4133.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add `m.login.terms` to the registration flow when consent tracking is enabled. **This makes the template arguments conditionally optional on a new `public_version` variable - update your privacy templates to support this.**
Copy link
Copy Markdown
Member Author

@turt2live turt2live Nov 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct me if I'm wrong about how to stack changelog entries

2 changes: 1 addition & 1 deletion synapse/rest/consent/consent_resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def _async_render_GET(self, request):
username = parse_string(request, "u", required=False, default="")
userhmac = None
has_consented = False
public_version = username != ""
public_version = username == ""
if not public_version:
userhmac = parse_string(request, "h", required=True, encoding=None)

Expand Down