This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Add a welcome page to the static resources#4289
Merged
Merged
Conversation
erikjohnston
approved these changes
Dec 11, 2018
Member
erikjohnston
left a comment
erikjohnston
left a comment
There was a problem hiding this comment.
Other than circleci seems to be sad
This is largely a precursor for the removal of the bundled webclient. The idea is to present a page at / which reassures people that something is working, and to give them some links for next steps. The welcome page lives at `/_matrix/static/`, so is enabled alongside the other `static` resources (which, in practice, means the client API is enabled). We'll redirect to it from `/` if we have nothing better to display there. It would be nice to have a way to disable it (in the same way that you might disable the nginx welcome page), but I can't really think of a good way to do that without a load of ickiness. It's based on the work done by @krombel for #2601.
richvdh
force-pushed
the
rav/welcome_page
branch
from
f516276 to
f537432
Compare
... otherwise it hangs
Codecov Report
@@ Coverage Diff @@
## release-v0.34.0 #4289 +/- ##
===================================================
- Coverage 73.52% 73.48% -0.05%
===================================================
Files 298 302 +4
Lines 29819 29894 +75
Branches 4881 4888 +7
===================================================
+ Hits 21925 21968 +43
- Misses 6458 6488 +30
- Partials 1436 1438 +2
Continue to review full report at Codecov.
|
This was referenced Dec 11, 2018
Merged
|
Welp, this didn't work: |
Contributor
|
@Ryonez wfm, can you give some more details? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is largely a precursor for the removal of the bundled webclient. The idea is to present a page at / which reassures people that something is working, and to give them some links for next steps.
The welcome page lives at
/_matrix/static/, so is enabled alongside the otherstaticresources (which, in practice, means the client API is enabled). We'll redirect to it from/if we have nothing better to display there.It would be nice to have a way to disable it (in the same way that you might disable the nginx welcome page), but I can't really think of a good way to do that without a load of ickiness.
It's based on the work done by @krombel for #2601.