This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Require event format version to parse or create events#4470
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4470 +/- ##
===========================================
- Coverage 74.77% 74.76% -0.01%
===========================================
Files 336 336
Lines 34031 34071 +40
Branches 5534 5538 +4
===========================================
+ Hits 25446 25474 +28
- Misses 7015 7025 +10
- Partials 1570 1572 +2 |
richvdh
approved these changes
Jan 25, 2019
| return e_id.to_string() | ||
|
|
||
| def new(self, key_values={}): | ||
| def new(self, room_version, key_values={}): |
Member
There was a problem hiding this comment.
one to fix another time, but this default for key_values looks disastrous, since we modify it and the modifications will get reused next time it is called.
Member
Author
There was a problem hiding this comment.
Good point! Will fix that in another PR
Member
Author
|
This PR introduced a bug fixed in b6b73a0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vast majority of this PR is simply adding in the format version when parsing events from federation. Otherwise, the actual changes are just the ones in
synapse/events/__init__.pyThis was #4451 before I accidentally hit merge on that one....