This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Support starting with no_tls = True and no TLS certificates#4606
Closed
hawkowl wants to merge 10 commits into
Closed
Support starting with no_tls = True and no TLS certificates#4606hawkowl wants to merge 10 commits into
hawkowl wants to merge 10 commits into
Conversation
Member
|
looks like this is based on #4522 |
Codecov Report
@@ Coverage Diff @@
## develop #4606 +/- ##
==========================================
Coverage ? 75.04%
==========================================
Files ? 338
Lines ? 34468
Branches ? 5619
==========================================
Hits ? 25865
Misses ? 7022
Partials ? 1581 |
richvdh
suggested changes
Feb 11, 2019
| if not self.no_tls: | ||
| self.tls_private_key = self.read_tls_private_key(self.tls_private_key_file) | ||
|
|
||
| self.tls_fingerprints = list(self._original_tls_fingerprints) |
Member
|
sorry, have superceded this with #4618 and co |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.