This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Fix kicking guest users in worker mode#4667
Merged
Merged
Conversation
When guest_access changes from allowed to forbidden all local guest users should be kicked from the room. This did not happen when revocation was received from federation on a worker. Presumably broken in #4141
erikjohnston
force-pushed
the
erikj/fix_revoke_guest_access_workers
branch
from
2b7013c to
e85aabb
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4667 +/- ##
===========================================
+ Coverage 75.27% 75.27% +<.01%
===========================================
Files 338 338
Lines 34626 34627 +1
Branches 5670 5670
===========================================
+ Hits 26064 26066 +2
- Misses 6966 6968 +2
+ Partials 1596 1593 -3 |
richvdh
approved these changes
Feb 18, 2019
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
Hey. What if, every time we made a change, we ran a bunch of tests against it. We could automate it. It would be glorious.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When guest_access changes from allowed to forbidden all local guest
users should be kicked from the room. This did not happen when
revocation was received from federation on a worker.
Presumably broken in #4141