Change documentation to support API without trailing slashes#4835
Change documentation to support API without trailing slashes#4835anoadragon453 wants to merge 2 commits into
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4835 +/- ##
==========================================
- Coverage 75.35% 67.7% -7.66%
==========================================
Files 340 340
Lines 34889 34889
Branches 5708 5708
==========================================
- Hits 26290 23620 -2670
- Misses 6988 9619 +2631
- Partials 1611 1650 +39 |
Codecov Report
@@ Coverage Diff @@
## develop #4835 +/- ##
==========================================
- Coverage 75.35% 75.3% -0.05%
==========================================
Files 340 340
Lines 34889 34943 +54
Branches 5708 5725 +17
==========================================
+ Hits 26290 26315 +25
- Misses 6988 7018 +30
+ Partials 1611 1610 -1 |
richvdh
left a comment
There was a problem hiding this comment.
Erm; with the exception of the one in ancient_architecture_notes.rst (which is, well, ancient), all of these endpoints will always have a slash where indicated?
For example: /_matrix/federation/v1/event is not a valid endpoint; the endpoint in question is /_matrix/federation/v1/event/{eventId}.
Also remember that ^/_matrix/federation/v1/send also matches _matrix/federation/v1/send_join/{roomId}/{eventId} and whilst it so happens that the same worker can handle both endpoints, I'm not convinced that this change is improving any clarity here.
|
Ah, it just clicked in my mind that these are all regexes. There doesn't seem to be much point in this PR then. 🌵 |
Some documentation changes to not give people the wrong idea about having trailing slashes on their API requests.
To be paired with #4793.