This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Fix bug where read-receipts lost their timestamps#4927
Merged
Conversation
Make sure that they are sent correctly over the replication stream. Fixes: #4898
jryans
reviewed
Mar 25, 2019
| @@ -0,0 +1 @@ | |||
| Batch up outgoing read-receipts to reduce federation traffic. | |||
Contributor
There was a problem hiding this comment.
Looks like the wrong description for this PR?
Member
Author
There was a problem hiding this comment.
nope, it's deliberately the same as the newsfile for the PR which introduced the bug (#4890, ftr), so that they get merged into one entry in the changelog
Codecov Report
@@ Coverage Diff @@
## develop #4927 +/- ##
===========================================
+ Coverage 60.43% 78.04% +17.6%
===========================================
Files 328 328
Lines 34067 34348 +281
Branches 5620 5708 +88
===========================================
+ Hits 20589 26807 +6218
+ Misses 12002 5913 -6089
- Partials 1476 1628 +152 |
erikjohnston
approved these changes
Mar 25, 2019
Member
erikjohnston
left a comment
erikjohnston
left a comment
There was a problem hiding this comment.
Would be nice if we had a sytest for read receipt timestamps.
Member
Wait, we do, duh. Never mind. |
Member
Author
|
lolz |
anoadragon453
added a commit
that referenced
this pull request
Mar 26, 2019
* develop: (141 commits) Make federation endpoints more tolerant of trailing slashes v2 (#4935) Fix ClientReplicationStreamProtocol.__str__ (#4929) Fix bug where read-receipts lost their timestamps (#4927) Use an explicit dbname for postgres connections in the tests. (#4928) Fix nginx example in ACME doc. (#4923) Refactor out state delta handling into its own class (#4917) Newsfile Use yaml safe_load Allow newsfragments to end with exclamation marks! (#4912) Some more porting to HomeserverTestCase and remove old RESTHelper (#4913) Clean up backoff_on_404 and metehod calls Update changelog.d/4908.bugfix Update Apache Setup To Remove Location Syntax (#4870) isort Newsfile Fix typo and add description Deny peeking into rooms that have been blocked Rejig testcase to make it more extensible Remove debug Add tests ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that they are sent correctly over the replication stream.
Fixes: #4898