Fix ClientReplicationStreamProtocol.__str__

changelog.d/4929.misc

@@ -0,0 +1 @@
+Fix `ClientReplicationStreamProtocol.__str__()`.

synapse/replication/tcp/protocol.py

@@ -364,8 +364,11 @@ def on_connection_closed(self):
             self.transport.unregisterProducer()
 
     def __str__(self):
+        addr = None
+        if self.transport:
+            addr = str(self.transport.getPeer())
         return "ReplicationConnection<name=%s,conn_id=%s,addr=%s>" % (
-            self.name, self.conn_id, self.addr,
+            self.name, self.conn_id, addr,
         )
 
     def id(self):
@@ -381,12 +384,11 @@ class ServerReplicationStreamProtocol(BaseReplicationStreamProtocol):
     VALID_INBOUND_COMMANDS = VALID_CLIENT_COMMANDS
     VALID_OUTBOUND_COMMANDS = VALID_SERVER_COMMANDS
 
-    def __init__(self, server_name, clock, streamer, addr):
+    def __init__(self, server_name, clock, streamer):
         BaseReplicationStreamProtocol.__init__(self, clock)  # Old style class
 
         self.server_name = server_name
         self.streamer = streamer
-        self.addr = addr
 
         # The streams the client has subscribed to and is up to date with
         self.replication_streams = set()

synapse/replication/tcp/resource.py

@@ -57,7 +57,6 @@ def buildProtocol(self, addr):
             self.server_name,
             self.clock,
             self.streamer,
-            addr
         )