Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Correct default POSTGRES_USER in Docker README#4987

Merged
erikjohnston merged 10 commits into
matrix-org:developfrom
f35f0ef9d0e827dae86552d3899f78fc:develop
Apr 4, 2019
Merged

Correct default POSTGRES_USER in Docker README#4987
erikjohnston merged 10 commits into
matrix-org:developfrom
f35f0ef9d0e827dae86552d3899f78fc:develop

Conversation

@f35f0ef9d0e827dae86552d3899f78fc
Copy link
Copy Markdown
Contributor

@f35f0ef9d0e827dae86552d3899f78fc f35f0ef9d0e827dae86552d3899f78fc commented Apr 2, 2019 •
edited
Loading

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file
  • Pull request includes a sign off

@f35f0ef9d0e827dae86552d3899f78fc
Copy link
Copy Markdown
Contributor Author

f35f0ef9d0e827dae86552d3899f78fc commented Apr 2, 2019 •
edited
Loading

Signed-off-by: Gabriel Eckerson 21157384+f35f0ef9d0e827dae86552d3899f78fc@users.noreply.github.com

@f35f0ef9d0e827dae86552d3899f78fc f35f0ef9d0e827dae86552d3899f78fc changed the title Correct default POSTGRES_USER Correct default POSTGRES_USER in Docker README Apr 2, 2019
@f35f0ef9d0e827dae86552d3899f78fc f35f0ef9d0e827dae86552d3899f78fc marked this pull request as ready for review April 2, 2019 03:30
@f35f0ef9d0e827dae86552d3899f78fc
Copy link
Copy Markdown
Contributor Author

f35f0ef9d0e827dae86552d3899f78fc commented Apr 2, 2019

This is where the default user is defined:

synapse/docker/conf/homeserver.yaml

Line 61 in 35442ef

user: "{{ POSTGRES_USER or "synapse" }}"

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2019 •
edited
Loading

Codecov Report

Merging #4987 into develop will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4987      +/-   ##
===========================================
- Coverage     60.6%   60.57%   -0.04%     
===========================================
  Files          332      331       -1     
  Lines        34235    34213      -22     
  Branches      5655     5655              
===========================================
- Hits         20749    20725      -24     
- Misses       12011    12013       +2     
  Partials      1475     1475

Closed
richvdh
richvdh suggested changes Apr 3, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As CONTRIBUTING.rst says, I'm afraid we cannot accept contributions without signoff from a legally-identifiable name.

Comment thread docker/conf/homeserver.yaml Outdated
@richvdh richvdh requested a review from a team April 4, 2019 09:05
@erikjohnston
Copy link
Copy Markdown
Member

erikjohnston commented Apr 4, 2019

Thanks for this!

@erikjohnston erikjohnston merged commit 40810b8 into matrix-org:develop Apr 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@richvdh richvdh richvdh requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@f35f0ef9d0e827dae86552d3899f78fc @erikjohnston @richvdh