Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Include systemd-python in Debian package to allow logging to journal#5261

Merged
richvdh merged 1 commit into
matrix-org:developfrom
silkeh:include-systemd-debian
Jun 27, 2019
Merged

Include systemd-python in Debian package to allow logging to journal#5261
richvdh merged 1 commit into
matrix-org:developfrom
silkeh:include-systemd-debian

Conversation

@silkeh
Copy link
Copy Markdown
Contributor

@silkeh silkeh commented May 26, 2019

Because 'systemd' is not included in 'all', it needs to be included explicitly.

This is a follow-up from #4339.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file
  • Pull request includes a sign off

@silkeh silkeh force-pushed the include-systemd-debian branch from 404f884 to d8aace2 Compare May 26, 2019 12:13
@richvdh
Copy link
Copy Markdown
Member

richvdh commented May 28, 2019

seems fair, but would you be able to put the change in the debian/changelog rather than a changelog.d file? https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.rst#debian-changelog has the details.

@silkeh silkeh force-pushed the include-systemd-debian branch from d8aace2 to 303077a Compare May 29, 2019 07:49
@silkeh
Copy link
Copy Markdown
Contributor Author

silkeh commented May 29, 2019

@richvdh Completely missed that, sorry 😥. Fixed!

By the way, the linked contributing section might benefit from a link to a setup guide for devscripts, what I got as changelog entry when running dch didn't look very acceptable.

@richvdh
Copy link
Copy Markdown
Member

richvdh commented May 29, 2019

By the way, the linked contributing section might benefit from a link to a setup guide for devscripts

Probably. I've generally assumed that if you're poking about in the debian packaging then you're familiar enough with this stuff to figure it out yourself, and if not, then debian can do a better job of documenting it than we can. But as you say, we could make this easier for people.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2019

Codecov Report

Merging #5261 into develop will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #5261      +/-   ##
===========================================
+ Coverage    63.07%   63.08%   +<.01%     
===========================================
  Files          326      326              
  Lines        35674    35667       -7     
  Branches      5854     5852       -2     
===========================================
- Hits         22501    22500       -1     
+ Misses       11594    11589       -5     
+ Partials      1579     1578       -1

Signed-off-by: Silke Hofstra <silke@slxh.eu>
@silkeh silkeh force-pushed the include-systemd-debian branch from 303077a to 00e945b Compare June 12, 2019 08:23
@silkeh
Copy link
Copy Markdown
Contributor Author

silkeh commented Jun 12, 2019

Now rebased on 1.0.0.

@richvdh
Copy link
Copy Markdown
Member

richvdh commented Jun 27, 2019

gah, sorry for forgetting about this.

@richvdh richvdh merged commit 457b8e4 into matrix-org:develop Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants