This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Downgrade crypto exception to a warning#5265
Closed
ReidAnderson wants to merge 2 commits into
Closed
Conversation
Member
|
I'm in the middle of rewriting a bunch of this code at the moment, including a substantial change to the exception handling here, so I'm going to hold on this for a minute |
Member
|
Closing this in favour of #5300. Thanks for the contribution though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
I was looking through issues and this should fix #4728. It was straightforward enough I thought I would just open a PR for it.
With that said, I'm not sure if this is actually something that's a good idea. There weren't any concerns raised on the issue, but obviously there can be a lot more to it than that. If assuming the generic exception should be treated as a warning is a no-go, or there's another reason why this isn't ideal feel free to just close the PR.