This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Remove libsqlite3-dev from required build dependencies.#5766
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## release-v1.3.0 #5766 +/- ##
==================================================
- Coverage 63.42% 63.28% -0.15%
==================================================
Files 333 331 -2
Lines 36652 36408 -244
Branches 6057 6012 -45
==================================================
- Hits 23246 23039 -207
+ Misses 11754 11726 -28
+ Partials 1652 1643 -9 |
anoadragon453
commented
Jul 25, 2019
erikjohnston
approved these changes
Jul 29, 2019
Member
|
I don't understand why this is needs and want to look into it |
richvdh
suggested changes
Jul 29, 2019
richvdh
suggested changes
Aug 12, 2019
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
can you update the PR title too please?
anoadragon453
changed the title
richvdh
reviewed
Aug 15, 2019
| @@ -1,3 +1,8 @@ | |||
| matrix-synapse-py3 (1.3.0) stable; urgency=medium | |||
Member
There was a problem hiding this comment.
I think this needs to be UNRELEASED or something, to avoid confusing the debian release scripts; see https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.rst#debian-changelog for the right incantation
richvdh
reviewed
Aug 15, 2019
Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The building of Synapse v1.2.0's debian packages complained about these dependencies until I added them, so I assume we need them now.
libdistro-info-perlseems to be only for debianbusterfor determining which debian version it was on.libsqlite3-dev...for sqlite3 stuff I suppose?