This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Allow HS to send emails when adding an email to the HS#6042
Merged
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the
/account/3pid/email|msisdn/requestTokenendpoints to useaccount_threepid_handler, similar to the other/requestTokenendpoints.First part of implementing MSC2290. The second part will be creating the new endpoints specified in the MSC.
I needed to use a feature branch here as for the flow to work POST /account/3pid needs to allow the homeserver to handle adding an email address to an account, which is what MSC2290 talks about anyways.So in the interest of having a single PR to handle MSC2290, let this PR serve as the precursor to that. It will land in a feature branch, then another PR to implement MSC2290 will also land in that feature branch. And then we can merge everything into develop :)This PR can be merged into develop. It will break users using old matrix clients trying to bind 3pids to identity servers but we accept this risk as practically known clients (i.e. Riot) wouldn't inform the user this was happening anyways.
Requires #6067