This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Remove unused bind_threepid method#6083
Closed
anoadragon453 wants to merge 1 commit into
Closed
Conversation
Merged
anoadragon453
force-pushed
the
anoa/remove_bind_threepid
branch
from
d2da51d to
4b98d72
Compare
richvdh
reviewed
Sep 23, 2019
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
errrm... it's used by /account/3pid/bind
Member
|
assuming this was a thinko on anoa's part until proven otherwise |
Member
Author
|
So it is! I missed it in PyCharm's "Find Usage" feature. It was under probable usage :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
bind_threepidmethod is no longer used by anything, so we should remove it else it's just cruft.