This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Transfer rooms on groups on room upgrade#6235
Merged
Merged
Conversation
anoadragon453
force-pushed
the
anoa/room_upgrade_groups
branch
from
f98420a to
0ab08d0
Compare
richvdh
reviewed
Oct 23, 2019
anoadragon453
force-pushed
the
anoa/room_upgrade_groups
branch
from
6d06916 to
cf2124d
Compare
anoadragon453
changed the base branch from
develop
to
anoa/room_upgrade_depublishing
richvdh
changed the base branch from
anoa/room_upgrade_depublishing
to
develop
richvdh
reviewed
Oct 30, 2019
anoadragon453
force-pushed
the
anoa/room_upgrade_groups
branch
from
cf2124d to
0287d03
Compare
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'e914cf12f': tweak changelog Re-add docstring, with caveats detailed Transfer upgraded rooms on groups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4897
Includes commits from #6232When a user joins a room that's been upgraded, have the server check if that room is present on any local groups. If so, add its successor to the group, then remove the upgraded room.When a server sees a room for the first time, or when a server upgrades a room itself, it will check if any groups it has contains that room, and if so removes it from the group and adds the upgraded room instead.
Sytest: matrix-org/sytest#737