This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Add *experimental* config option to support multiple databases#6258
Closed
erikjohnston wants to merge 8 commits into
Closed
Add *experimental* config option to support multiple databases#6258erikjohnston wants to merge 8 commits into
erikjohnston wants to merge 8 commits into
Conversation
Member
Author
|
I've disabled the follow import stuff for now. We weren't using it before and it seems a bit overly aggressive. |
richvdh
reviewed
Oct 31, 2019
Member
richvdh
left a comment
There was a problem hiding this comment.
I want to take this out of the queue until some of the groundwork is in place (and the conflicts are fixed...)
This encapsulates config for a given database and is the way to get new connections.
This is not currently hooked up to any configuration parameters.
This allows us to test if using multiple databases actually works.
4655f4c to
6d015de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of this is a refactor to remove the
get_db_poolandget_db_connfunctions from the homeserver god object.Based on #6240 and #6245.
Commits independently reviewable.
The new options replace
databaseconfig, and look like:I'm not super happy about this config format, hence why its undocumented and experimental, but its useful to allow us to test. Once I've played around with it a bit more, possibly adding support having multiple
statedata stores, then it should be easy to change or stabilise.