This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Prevent redacted events from appearing in message search#6377
Merged
Conversation
richvdh
previously requested changes
Nov 22, 2019
anoadragon453
force-pushed
the
anoa/search_redacted_events
branch
from
985ba7f to
916e71b
Compare
richvdh
previously requested changes
Dec 4, 2019
| include the previous states content in the unsigned field. | ||
| allow_rejected (bool): If True return rejected events. | ||
| allow_rejected: If True, return rejected events. | ||
| allow_redacted: If True, return redacted events. |
Member
There was a problem hiding this comment.
could you document the interaction between check_redacted and allow_redacted more clearly? What is the meaning of check_redacted if allow_redacted is False?
(maybe we should replace check_redacted with a tristate?)
Member
Author
There was a problem hiding this comment.
Indeed, I've switched it out for an enum now, let me know what you think.
richvdh
approved these changes
Dec 5, 2019
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
lgtm, though there's something wrong with the CI
…rch_redacted_events * 'develop' of github.com:matrix-org/synapse: (100 commits) Move get_state methods into FederationHandler (#6503) Allow SAML username provider plugins (#6411) Fix race which caused deleted devices to reappear (#6514) Refactor get_events_from_store_or_dest to return a dict (#6501) Remove redundant code from event authorisation implementation. (#6502) Newsfile Silence mypy errors for files outside those specified Newsfile Phone home stats DB reporting should not assume a single DB. Update comment Drop unused index Convert _censor_redactions to async since it awaits on coroutines Only start censor background job after indices are created Newsfile Newsfile Fix make_deferred_yieldable to work with coroutines Newsfile Fix support for SQLite 3.7. Better errors regarding changing avatar_url (#6497) 1.7.0rc1 ...
Member
Author
|
Unfortunately it looks like this doesn't entirely fix the problem. Redacted events are still returned. The test wasn't correctly testing that a redacted event didn't appear in the results. |
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'fc316a489': Prevent redacted events from appearing in message search (#6377)
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1454
Removes an event from theevent_searchtable upon redaction.Associated sytest: matrix-org/sytest#747
Note: This PR is not a complete solution. #6522 should also be considered.