Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Fix issue #6406 parameter mismatch#6441

Merged
erikjohnston merged 2 commits into
matrix-org:developfrom
syamgk:fix-parameter-mismatch
Dec 4, 2019
Merged

Fix issue #6406 parameter mismatch#6441
erikjohnston merged 2 commits into
matrix-org:developfrom
syamgk:fix-parameter-mismatch

Conversation

@syamgk
Copy link
Copy Markdown
Contributor

@syamgk syamgk commented Nov 29, 2019

Fixes #6406

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file
  • Pull request includes a sign off
  • Code style is correct (run the linters)

@syamgk syamgk force-pushed the fix-parameter-mismatch branch from 72ceb27 to e339581 Compare November 29, 2019 17:43
@syamgk syamgk changed the base branch from master to develop November 29, 2019 17:45
@syamgk syamgk changed the title Issue #6406 Fix parameter missmatch Fix issue #6406 Fix parameter missmatch Nov 29, 2019
@richvdh richvdh changed the title Fix issue #6406 Fix parameter missmatch Fix issue #6406 parameter mismatch Dec 2, 2019
Comment thread changelog.d/6406.bugfix Outdated
@syamgk syamgk force-pushed the fix-parameter-mismatch branch from e339581 to 1e99e7c Compare December 3, 2019 05:16
Signed-off-by: Syam G Krishnan <syamgk01@gmail.com>
Signed-off-by: Syam G Krishnan <syamgk@gmail.com>
@syamgk syamgk force-pushed the fix-parameter-mismatch branch from 1e99e7c to b62c9db Compare December 4, 2019 07:34
@syamgk syamgk requested a review from richvdh December 4, 2019 11:51
@richvdh richvdh requested review from a team and removed request for richvdh December 4, 2019 12:14
Copy link
Copy Markdown
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The False just indicated that the email shouldn't be added to the identity server, which we don't do now.

@erikjohnston erikjohnston merged commit b944901 into matrix-org:develop Dec 4, 2019
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit 'b9449012d':
  Add changelog file
  Issue #6406 Fix parameter mismatch
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants