This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Add auth events as per spec.#6556
Merged
Merged
Conversation
Previously we tried to be clever and filter out some unnecessary event IDs to keep the auth chain small, but that had some annoying interactions with state res v2 so we stop doing that for now.
erikjohnston
force-pushed
the
erikj/fix_auth_event_selection
branch
from
b24a5e1 to
5aed4e9
Compare
richvdh
approved these changes
Dec 16, 2019
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
seems plausible modulo the below.
needs to target the release branch?
| """ | ||
| return self.store.is_server_admin(user) | ||
|
|
||
| @defer.inlineCallbacks |
Member
There was a problem hiding this comment.
turning this from a deferred-returning function to an immediate one without updating the call sites feels like it might bite us later? Better to return defer.suceed() or add a yield defer.succeed() ?
Not that bothered though. We'll probably catch it when we update the call sites...
| @@ -0,0 +1 @@ | |||
| Fix a cause of state resets in v5. | |||
Member
There was a problem hiding this comment.
v5 of what?
Itym room version 2 and onwards.
erikjohnston
added a commit
that referenced
this pull request
Dec 16, 2019
Previously we tried to be clever and filter out some unnecessary event IDs to keep the auth chain small, but that had some annoying interactions with state res v2 so we stop doing that for now.
richvdh
added a commit
that referenced
this pull request
Dec 18, 2019
Synapse 1.7.1 (2019-12-18) ========================== This release includes several security fixes as well as a fix to a bug exposed by the security fixes. Administrators are encouraged to upgrade as soon as possible. Security updates ---------------- - Fix a bug which could cause room events to be incorrectly authorized using events from a different room. ([\#6501](#6501), [\#6503](#6503), [\#6521](#6521), [\#6524](#6524), [\#6530](#6530), [\#6531](#6531)) - Fix a bug causing responses to the `/context` client endpoint to not use the pruned version of the event. ([\#6553](#6553)) - Fix a cause of state resets in room versions 2 onwards. ([\#6556](#6556), [\#6560](#6560)) Bugfixes -------- - Fix a bug which could cause the federation server to incorrectly return errors when handling certain obscure event graphs. ([\#6526](#6526), [\#6527](#6527))
This was referenced Dec 18, 2019
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '3fbe5b7ec': Add auth events as per spec. (#6556)
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '5ca2cfadc': Add auth events as per spec. (#6556)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we tried to be clever and filter out some unnecessary event
IDs to keep the auth chain small, but that had some annoying
interactions with state res v2 so we stop doing that for now.
Fixes #6520