This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Fix some test failures when frozen_dicts are enabled#6642
Merged
Conversation
erikjohnston
approved these changes
Jan 6, 2020
| initial_state[(EventTypes.PowerLevels, "")] = new_power_levels | ||
|
|
||
| # Assign this power level to the requester | ||
| new_power_levels = {k: v for k, v in power_levels.items() if k != "users"} |
Member
There was a problem hiding this comment.
A comment to say that we're working around the fact this could be a frozendict would be good, I got quite confused.
| @@ -0,0 +1 @@ | |||
| Fix test failures when frozen_dicts are enabled. | |||
Member
There was a problem hiding this comment.
Won't these effect real world usage too?
Member
Author
There was a problem hiding this comment.
affect ;-p
yeah, I guess so.
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'ba897a759': Fix some test failures when frozen_dicts are enabled (#6642)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4026