Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Fix /events/:event_id deprecated API.#6731

Merged
erikjohnston merged 3 commits into
developfrom
erikj/fix_events_event_id
Jan 20, 2020
Merged

Fix /events/:event_id deprecated API.#6731
erikjohnston merged 3 commits into
developfrom
erikj/fix_events_event_id

Conversation

@erikjohnston
Copy link
Copy Markdown
Member

No description provided.

@erikjohnston erikjohnston requested a review from a team January 17, 2020 17:30
Copy link
Copy Markdown
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks plausible. Any idea when this got introduced?

@@ -78,6 +78,7 @@ def __init__(self, hs):
super(EventRestServlet, self).__init__()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could probably remove the TODO at line 73...

@erikjohnston
Copy link
Copy Markdown
Member Author

Ah yes, it got broke in #5226

@erikjohnston erikjohnston merged commit 74b7446 into develop Jan 20, 2020
@erikjohnston erikjohnston deleted the erikj/fix_events_event_id branch February 5, 2020 17:35
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit '74b74462f':
  Fix `/events/:event_id` deprecated API. (#6731)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants